Publish precompiled wheels in Github release and add wheel index #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 16, 2024 15:51
I will try to finish addressing |
added 6 commits
September 21, 2024 00:48
|
@liruilong940607 thank you very much for the feedback. I tried to address your comments. Any remaining concern or improvements suggestion before I publish the PR? |
martinResearch
commented
Sep 21, 2024
| wheels_per_local_version = {} | ||
| for wheel in wheels: | ||
| local_version = wheel["local_version"] | ||
| if local_version not in wheels_per_local_version: |
There was a problem hiding this comment.
if local_version is not and and local_version not in wheels_per_local_version:
|
This looks great! Thanks for all the updates! I'm doing test now |
liruilong940607
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
I tested it out and did some fixes here and there. Now I think it is good to go. Thanks a lot for digging into this @martinResearch !
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a mechanism to publish precompiled wheels in github releases and pypi and add a wheel index html file to be able to install precompiled wheels for a specific pytorch and cuda version using a single line like
One can also omit the
pt20cu118and usebut then the full version needs to be specified to make sure one gets the right pytorch and cuda version.
The full list of pre-compiled wheel can be found here
Is that a solution you would potentially be happy to merge in your repository?
This PR also tries to upload all the wheels to pypi I am not sure pipy will allows us to upload wheels with "+" sign in the wheel name (i.e using local version to specify the cuda and pytorch versions), and I am not sure whe want to upload these wheels to pypi, so the upload step could be removed for the precompiled wheels